Skip to content

Comments

warn when overwriting file at installation#8386

Merged
Secrus merged 2 commits intopython-poetry:masterfrom
dimbleby:wheel-install-warn-overwrite
Sep 11, 2023
Merged

warn when overwriting file at installation#8386
Secrus merged 2 commits intopython-poetry:masterfrom
dimbleby:wheel-install-warn-overwrite

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Aug 30, 2023

see #8382 for context - if two packages install the same file it would be useful to know this.

I'm in two minds about this warning, I expect both true and false positives are rather rare and it's hard to evaluate which matters more

IMO probably a net gain, but I don't care enough to fight for it.

@Secrus Secrus enabled auto-merge (squash) September 11, 2023 11:43
@Secrus Secrus merged commit 6d646f4 into python-poetry:master Sep 11, 2023
@dimbleby dimbleby deleted the wheel-install-warn-overwrite branch September 11, 2023 12:10
@github-actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants