warn when overwriting file at installation#8386
Merged
Secrus merged 2 commits intopython-poetry:masterfrom Sep 11, 2023
Merged
Conversation
Secrus
approved these changes
Sep 11, 2023
Secrus
approved these changes
Sep 11, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #8382 for context - if two packages install the same file it would be useful to know this.
I'm in two minds about this warning, I expect both true and false positives are rather rare and it's hard to evaluate which matters more
this warning would surely have given a clue in 0-byte files getting unpacked #8382: knowing about it when it really is unwanted seems very desirable
adding this warning will likely expose this repository to a small trickle of issue reports, of varying legitimacy
pecan.whl archive pypa/installer#182, Unable to install salt wheel pypa/installer#194IMO probably a net gain, but I don't care enough to fight for it.