fix urljoin for arbitrary URL protocols#8020
Merged
radoering merged 9 commits intopython-poetry:masterfrom Sep 17, 2023
Merged
Conversation
Contributor
|
I can't tell what this fixes, a test case showing the point would be helpful |
Contributor
Author
This works around an issue with urllib.parse.urljoin where it only handles relative URLs for protocols contained in urllib.parse.uses_relative. As it happens common protocols used with git, like ssh or git+ssh are not in that list.
Contributor
Author
|
@dimbleby, I've added tests. Doing so required a bit of refactoring to make testing easier since actually cloning the test repo via SSH would require significant effort without a correspondingly large benefit. The core the of the change, as before, is |
Closed
3 tasks
radoering
approved these changes
Sep 17, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around an issue with urllib.parse.urljoin where it only handles relative URLs for protocols contained in urllib.parse.uses_relative. As it happens common protocols used with git, like ssh or git+ssh are not in that list.
For more info: #6499 (comment)
Pull Request Check List
Resolves: #6499