Merged
Conversation
Contributor
Author
|
As far as I understand, I should be able to re-achieve the same behaviour by using https://cacheyou.readthedocs.io/en/latest/storage.html#separatebodyfilecache, as |
radoering
approved these changes
May 24, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #7961
Reverting #7916 (funny how it's the same issue numbers reverted) as the cached file from
cachecontrolcontains the entire HTTP response, not just its content. Terribly sorry for that, I don't know how this slipped when debugging.There's still probably some optimizations we could do but we should prioritize making Poetry correct again. The PR reverts the old unwanted behaviours:
An unwanted file copy operation
An unwanted slow file copy operation, as we perform it with a relative small chunk size
An unwanted "Downloading " log when in reality we are not
Added tests for changed code.
Updated documentation for changed code.