fix: explicit source dependency is not satisfied by direct origin#7973
fix: explicit source dependency is not satisfied by direct origin#7973radoering merged 2 commits intopython-poetry:masterfrom
Conversation
8d072c3 to
298c906
Compare
|
So far as the code change goes I'm basically reviewing my own suggestion here. Looks fine to me, but this is not an independent review. I think I would have expected to write a testcase here that more closely follows the actual problem as laid out in the issue report. Probably something in I always find those testcases unpleasant to write, which is partly what put me off doing anything with this one in the first place. If you can convince yourself - and someone with the commit bit - that what you have is sufficient, then your life will be easier. |
298c906 to
67dbb5e
Compare
|
I added a test, LMK if that's what you were looking for ;) |
b38ed8f to
4b0a796
Compare
|
I added a solver test. There is some overlap with the installer test, but since it's not (only) an installer issue but first of all a solver issue (i.e. the package with the explicit source is not only not installed but not locked), it made sense to me. Now, we should have more than sufficient test coverage. 😀 |
|
Deploy preview for website ready! Built with commit 42364f1. |
2a973d9 to
42364f1
Compare
) Co-authored-by: David Hotham <[email protected]> Co-authored-by: Randy Döring <[email protected]> (cherry picked from commit c77ffbd)
) Co-authored-by: David Hotham <[email protected]> Co-authored-by: Randy Döring <[email protected]> (cherry picked from commit c77ffbd)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Resolves: #7722
cc @dimbleby