Merged
Conversation
radoering
approved these changes
May 20, 2023
radoering
force-pushed
the
atomic-downloads
branch
from
76d8c19 to
cfd6fdd
Compare
poetry-bot bot
pushed a commit
that referenced
this pull request
May 20, 2023
(cherry picked from commit c5d2c6b)
Merged
radoering
pushed a commit
that referenced
this pull request
May 20, 2023
(cherry picked from commit c5d2c6b)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sad that this code is so similar to the executor's
_download_archive(), maybe one day someone will clean this upmeanwhile let's copy the fix from there to here, so as not to leave partially downloaded files lying around