Fix handling of init dependencies#786
Conversation
|
Python 2.7 and 3.5 are failing because of different ordering of dependencies in pyproject.toml file. I guess I'll have to use multiple asserts per test as workaround. |
|
Failures look unrelated. |
brycedrennan
left a comment
There was a problem hiding this comment.
@silenc3r thanks for contributing to poetry!
We're going to need those tests to pass before we can merge. If you could rebase off the latest master maybe the tests will work this time?
2679324 to
7103a2a
Compare
|
Tests succeed when run in isolation, i.e.
It seems to be some kind of bytes to string conversion error in Cleo. Sorry but I don't have time to investigate that. |
|
Why do you say the tests are broken on master? I don't see any recent failures: |
|
It fails locally both on OpenSUSE Tumbleweed (Python 3.7.3) and Fedora 30 (Python 3.7.4). Steps to reproduce: |
|
Interesting - thanks for the heads up on that. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey @silenc3r, could you please rebase your PR on the current master branch? Thanks a lot! fin swimmer |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Make sure that command line dependencies (and dev dependencies) are always handled properly.
Closes #711.