Skip to content

Comments

Fix handling of init dependencies#786

Closed
silenc3r wants to merge 2 commits intopython-poetry:masterfrom
silenc3r:init-dependencies
Closed

Fix handling of init dependencies#786
silenc3r wants to merge 2 commits intopython-poetry:masterfrom
silenc3r:init-dependencies

Conversation

@silenc3r
Copy link

@silenc3r silenc3r commented Jan 8, 2019

  • Added tests for changed code.
  • Updated documentation for changed code.

Make sure that command line dependencies (and dev dependencies) are always handled properly.

Closes #711.

@silenc3r
Copy link
Author

silenc3r commented Jan 8, 2019

Python 2.7 and 3.5 are failing because of different ordering of dependencies in pyproject.toml file.
Python 2.7 seems to sort dependencies in reverse order, while in Python 3.5 order is not deterministic.

I guess I'll have to use multiple asserts per test as workaround.

@silenc3r
Copy link
Author

silenc3r commented Jan 8, 2019

Failures look unrelated.

@brycedrennan brycedrennan added the kind/bug Something isn't working as expected label Aug 17, 2019
Copy link
Contributor

@brycedrennan brycedrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silenc3r thanks for contributing to poetry!

We're going to need those tests to pass before we can merge. If you could rebase off the latest master maybe the tests will work this time?

@silenc3r
Copy link
Author

silenc3r commented Sep 3, 2019

Tests succeed when run in isolation, i.e. pytest tests/console/commands/test_init.py but fail when run with make test.

test_interactive_with_dependencies is broken on current master as well.

It seems to be some kind of bytes to string conversion error in Cleo.

Sorry but I don't have time to investigate that.

@brycedrennan
Copy link
Contributor

brycedrennan commented Sep 3, 2019

Why do you say the tests are broken on master? I don't see any recent failures:
https://travis-ci.org/sdispater/poetry/branches

@silenc3r
Copy link
Author

silenc3r commented Sep 3, 2019

It fails locally both on OpenSUSE Tumbleweed (Python 3.7.3) and Fedora 30 (Python 3.7.4).

Steps to reproduce:

git clone https://github.com/sdispater/poetry.git
cd poetry
poetry install
poetry shell
make test

@silenc3r silenc3r closed this Sep 3, 2019
@silenc3r silenc3r reopened this Sep 3, 2019
@brycedrennan
Copy link
Contributor

Interesting - thanks for the heads up on that.

@stale
Copy link

stale bot commented Nov 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 13, 2019
@sdispater sdispater added stale and removed wontfix labels Nov 14, 2019
@stale stale bot removed the stale label Nov 14, 2019
@finswimmer
Copy link
Member

Hey @silenc3r,

could you please rebase your PR on the current master branch? Thanks a lot!

fin swimmer

@finswimmer
Copy link
Member

@silenc3r I forked your PR and make the rebase: #2587

Thanks a lot for your contribution 👍

@finswimmer finswimmer closed this Jun 20, 2020
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"poetry init --dependency django" does nothing

4 participants