installer tests should verify result of install#7759
Merged
radoering merged 1 commit intopython-poetry:masterfrom Apr 3, 2023
Merged
installer tests should verify result of install#7759radoering merged 1 commit intopython-poetry:masterfrom
radoering merged 1 commit intopython-poetry:masterfrom
Conversation
dimbleby
force-pushed
the
installer-tests-should-check-result
branch
2 times, most recently
from
8de0959 to
5debd39
Compare
radoering
approved these changes
Apr 3, 2023
radoering
force-pushed
the
installer-tests-should-check-result
branch
from
5debd39 to
8d6438c
Compare
2 tasks
adriangb
pushed a commit
to adriangb/poetry
that referenced
this pull request
Apr 5, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently there's one test that passes even though the install didn't succeed. cf discussion in #7498
fix that test and add assertions so that it doesn't happen again