Merged
Conversation
2 tasks
radoering
added
area/installer
radoering
approved these changes
Mar 18, 2023
Merged
poetry-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2023
(cherry picked from commit 8db1f00)
4 tasks
radoering
pushed a commit
that referenced
this pull request
Mar 18, 2023
(cherry picked from commit 8db1f00)
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7572
explicitly declines to fix #7585, by choosing to call
validate_record(), on the grounds thatUnless some installer starts enforcing this there'll never be any pressure for anyone to fix their packages, poetry has generally been willing to "go first" on such things (eg see insistence on pep517 builds)
as it happens, this validation also found some errors in poetry's own test fixtures