fix: append subdirectory to archive path (#7575)#7580
Merged
radoering merged 3 commits intopython-poetry:masterfrom Mar 4, 2023
Merged
fix: append subdirectory to archive path (#7575)#7580radoering merged 3 commits intopython-poetry:masterfrom
radoering merged 3 commits intopython-poetry:masterfrom
Conversation
radoering
requested changes
Mar 3, 2023
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
LGTM.
In addition, I think we can remove
poetry/src/poetry/installation/executor.py
Lines 589 to 596 in 3e32a4f
because this part was supposed to consider the subdirectory but apparently it does nothing.
Member
|
Actually, if we remove this code, we don't need |
Contributor
Author
|
Yep those lines do nothing... have removed |
radoering
approved these changes
Mar 4, 2023
radoering
added
area/installer
poetry-bot bot
pushed a commit
that referenced
this pull request
Mar 4, 2023
(cherry picked from commit f27308f)
radoering
pushed a commit
that referenced
this pull request
Mar 4, 2023
(cherry picked from commit f27308f)
Closed
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #7575
From @nikowatari's suggestion (#755 (comment)) with added test.