don't set package pretty_version#7305
Merged
radoering merged 1 commit intopython-poetry:masterfrom Jan 22, 2023
Merged
Conversation
Contributor
Author
|
test failure looks spurious: hard to believe that this MR changes that but only on Windows 3.10 (also this is clearly an over-specified test, though I'm not proposing to do anything about that since I assume the problem will go away on retry) |
dimbleby
force-pushed
the
no-pretty-version
branch
from
3ebb583 to
eee2d54
Compare
radoering
approved these changes
Jan 22, 2023
radoering
force-pushed
the
no-pretty-version
branch
from
eee2d54 to
6f63e6d
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pretty_version on the Package is pointless, it can always just be taken from the regular version's
.text.This is the only place in the codebase that sets it; and clearly it's not doing anything useful.
This is a prelude to corresponding tidying in poetry-core