Pass all pyproject.toml and poetry.lock from subdirectories#7295
Pass all pyproject.toml and poetry.lock from subdirectories#7295xinbinhuang wants to merge 2 commits intopython-poetry:masterfrom
pyproject.toml and poetry.lock from subdirectories#7295Conversation
|
Hi @neersighted, I believe #7239 is for a different thing - |
|
It's for the same thing, the pre-commit hook. The fact that |
sure thing. I've updated the description to link to that issue, but I don't think this PR alone is enough to close it. Because |
|
That is tracked by a separate issue, #7240. The issue body and title are still the definitive indicator as to what an issue tracks. |
|
ah that makes sense. Can you help review this PR? are there any concerns on merging it or let me know if you have any comment you want me to address. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
relates: #7239 #7247
This change pass all
pyproject.tomlandpoetry.lockfrom subdirectories. In a monorepo setup,pyproject.tomlandpoetry.lockmay not exists in the root folder. Since users need to configure the--directoryflag to control which folder to run the check on, I'll be easier if the hook by default supply all files so users don't need to configure bot the flag and thefilesfield. Also, the default hardcodedfilesis a bit hidden and hard to find without looking at the source code.Pull Request Check List