Skip to content

Comments

fix poetry shell for zsh if space character in venv path#7245

Merged
radoering merged 7 commits intopython-poetry:masterfrom
dimstunt:fix/7244
Jan 20, 2024
Merged

fix poetry shell for zsh if space character in venv path#7245
radoering merged 7 commits intopython-poetry:masterfrom
dimstunt:fix/7244

Conversation

@dimstunt
Copy link
Contributor

@dimstunt dimstunt commented Dec 23, 2022 •
edited
Loading

fix zsh: poetry shell doesn't work if space character in .venv path

Pull Request Check List

Resolves: #7244

Confirmed working on bash, zsh

@dimstunt
Update shell.py
19133be 
fix zsh: poetry shell doesn't work if space character in .venv path

python-poetry#7244
PabloEmidio
PabloEmidio previously approved these changes Dec 25, 2022
View reviewed changes
PabloEmidio
PabloEmidio reviewed Dec 25, 2022
View reviewed changes
Copy link
Contributor

@PabloEmidio PabloEmidio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On PEP 8, there is the following say about triple quote

For triple-quoted strings, always use double quote characters to be consistent with the docstring convention in PEP 257.

@jaklan
Copy link

jaklan commented Dec 25, 2022

Or even simpler:
c.sendline(f'emulate bash -c ". {shlex.quote(str(activate_path))}"')
(so we get emulate bash -c ". '/some path/activate'")

But the safest one would be:
c.sendline(f"emulate bash -c {shlex.quote(f'. {shlex.quote(str(activate_path))}')}")
(so we get emulate bash -c '. '"'"'/some path/activate'"'"'')

@DennisTheMenace780
Copy link

DennisTheMenace780 commented Jan 22, 2023

Any updates on whether this will get merged in the near future? I am running into the same issue on macOS unfortuantely.

@dimstunt
Copy link
Contributor Author

dimstunt commented Jan 31, 2023

@PabloEmidio when you have a chance, please check this.

@PabloEmidio
Copy link
Contributor

PabloEmidio commented Feb 1, 2023

@PabloEmidio when you have a chance, please check this.

For what I saw, it should do it. Could any test be added to validate this scenary?

@dimstunt
Copy link
Contributor Author

dimstunt commented Feb 9, 2023

@PabloEmidio when you have a chance, please check this.

For what I saw, it should do it. Could any test be added to validate this scenary?

Not fast because the executing bash script is moked, and I don't have enough expertise in pytest to change that.

radoering
radoering reviewed Jan 20, 2024
View reviewed changes
@radoering
Copy link
Member

radoering commented Jan 20, 2024

pre-commit.ci autofix

@radoering radoering changed the title fix poetry shell doesn't work if space character in .venv path fix poetry shell for zsh if space character in venv path Jan 20, 2024
@radoering radoering merged commit 47fe2ac into python-poetry:master Jan 20, 2024
@radoering radoering mentioned this pull request Feb 17, 2024
Merged
@github-actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radoering radoering radoering approved these changes

+1 more reviewer

@PabloEmidio PabloEmidio PabloEmidio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zsh: poetry shell doesn't work if space character in .venv path

6 participants

@dimstunt @jaklan @DennisTheMenace780 @PabloEmidio @radoering @Secrus