Skip to content

Comments

Add lockfile as an explicit dependency#7169

Merged
radoering merged 3 commits intopython-poetry:masterfrom
orf:add-explicit-dep
Dec 11, 2022
Merged

Add lockfile as an explicit dependency#7169
radoering merged 3 commits intopython-poetry:masterfrom
orf:add-explicit-dep

Conversation

@orf
Copy link
Contributor

@orf orf commented Dec 10, 2022 •
edited by radoering
Loading

Resolves #7171

Whilst exploring why Homebrew/homebrew-core#117779 is failing, I saw the following traceback:

  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/puzzle/provider.py", line 37, in <module>
    from poetry.vcs.git import Git
  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/vcs/git/__init__.py", line 3, in <module>
    from poetry.vcs.git.backend import Git
  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/vcs/git/backend.py", line 21, in <module>
    from poetry.utils.authenticator import get_default_authenticator
  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/utils/authenticator.py", line 15, in <module>
    import lockfile
ModuleNotFoundError: No module named 'lockfile'

The lockfile module was missing from the resources block when it should have been present. However, Poetry is using the lockfile package directly despite it being brought in via an transient dependency:

poetry/src/poetry/utils/authenticator.py

Line 15 in aa48815

import lockfile

This MR adds it as a direct dependency.

dimbleby
dimbleby reviewed Dec 10, 2022
View reviewed changes
lazka added a commit to msys2/MINGW-packages that referenced this pull request Dec 10, 2022
@lazka
poetry: add missing lockfile dep
70ab85b 
it is also missing upstream, see
python-poetry/poetry#7169
@radoering radoering added impact/backport Requires backport to stable branch backport/1.3 labels Dec 11, 2022
@radoering radoering merged commit e4dad22 into python-poetry:master Dec 11, 2022
poetry-bot bot pushed a commit that referenced this pull request Dec 11, 2022
@orf @github-actions
Add lockfile as an explicit dependency (#7169)
c7e9b41 
(cherry picked from commit e4dad22)
@poetry-bot poetry-bot bot mentioned this pull request Dec 11, 2022
Merged
radoering pushed a commit that referenced this pull request Dec 11, 2022
@orf @radoering
Add lockfile as an explicit dependency (#7169)
8921a60 
(cherry picked from commit e4dad22)
@orf orf deleted the add-explicit-dep branch December 11, 2022 13:01
@neersighted neersighted mentioned this pull request Dec 12, 2022
Merged
@bryteise bryteise mentioned this pull request Mar 8, 2023
Closed
2 tasks
@sdpkjc sdpkjc mentioned this pull request Jun 5, 2023
Merged
18 tasks
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radoering radoering radoering approved these changes

+1 more reviewer

@dimbleby dimbleby dimbleby left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

impact/backport Requires backport to stable branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dependency lockfile seemingly missing in 1.3.0

3 participants

@orf @dimbleby @radoering