Relay return code as exit code when running script#6824
Merged
radoering merged 3 commits intopython-poetry:masterfrom Nov 16, 2022
Merged
Relay return code as exit code when running script#6824radoering merged 3 commits intopython-poetry:masterfrom
radoering merged 3 commits intopython-poetry:masterfrom
Conversation
rc-mattschwager
force-pushed
the
master
branch
2 times, most recently
from
bc7e2ea to
7699c90
Compare
Closed
finswimmer
previously requested changes
Nov 5, 2022
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot for contribution 👍
The change looks reasonable to me. Could you please try to add a test for it?
fin swimmer
radoering
approved these changes
Nov 16, 2022
radoering
changed the title
Contributor
Author
|
Thanks for writing a test, that looks like a doozy! |
neersighted
added
area/cli
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #6801
I didn't see any relevant tests for the
run_scriptfunctionality, so I'm not sure how best to test it. I did confirm the fix by running the relevant functionality locally and noting the correct exit code:Let me know the best way to add an automated test 👍