[1.2] fix: fix support for packaging v20.4#6808
Merged
radoering merged 1 commit intopython-poetry:1.2from Nov 5, 2022
Merged
Conversation
4 tasks
4 tasks
neersighted
approved these changes
Oct 16, 2022
Closed
radoering
approved these changes
Nov 5, 2022
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
There might not be another 1.2 release. Nevertheless I'm going to merge this so it's fixed at least in the 1.2 branch.
Poetry v1.2.2 does not work with packaging v20.4 (which is an allowed version of packaging in the pyproject.toml file). This is because the `from packaging.utils import NormalizedName` line before [packaging v20.5][1] only works if `typing.TYPE_CHECKING` is True. This is not an issue on the `master` branch, since there this import is already hidden behind an `if TYPE_CHECKING:` guard. However, the v1.2 branch never cherry-picked the appropriate commit adding this change. [1]: pypa/packaging@eca30e0 Fixes: python-poetry@04c5cbf
radoering
force-pushed
the
fix-packaging-v20.4
branch
from
beef142 to
020ebe5
Compare
|
To help others - to work around this you can update the version of packaging with |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug only affects the
1.2branch (caused by a bad cherry-pick frommaster)Poetry v1.2.2 does not work with packaging v20.4 (which is an allowed version of packaging in the pyproject.toml file).
This is because the
from packaging.utils import NormalizedNameline before packaging v20.5 only works iftyping.TYPE_CHECKINGis True.This is not an issue on the
masterbranch, since there this import is already hidden behind anif TYPE_CHECKING:guard. However, the v1.2 branch never cherry-picked the appropriate commit adding this change.See the current
masterbranch, which works fine:poetry/src/poetry/installation/installer.py
Lines 21 to 26 in 16046d9
Fixes: 04c5cbf (this was the broken cherry-pick)
Pull Request Check List
Resolves: #6807
packagingv20.4, and I can't see an easy way to do this.