fix: remove exception when keyring is locked #6612
fix: remove exception when keyring is locked #6612MatthieuBizien wants to merge 1 commit intopython-poetry:masterfrom
Conversation
8792125 to
45c8517
Compare
|
Thanks for starting on this! There are many more errors Keyring has been throwing (one of the reasons no one has started on this yet) -- see all the dupes of #1917 for situations we should handle. We also most definitely need a unit/regression test for this. |
|
When will this be merged? We get this a lot on our enterprise HPC at work and have to run a workaround environment variable all the time. |
I was looking through all linked issues for Exceptions poetry could catch to prevent this. I bumped into some problems. Sometimes the keyring raises a RuntimeError. I guess discarding that isn't a problem. However how to catch |
|
I would agree with you: catching That ought to catch the great majority of cases; and if keyring does take the view that it can raise any old exception and callers are supposed to handle them all - well that will be a simple enough thing to change later. |
|
Ok, so I opened an updated PR: #8227 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #1917