Handle locked pip version on Windows#6430
Merged
radoering merged 2 commits intopython-poetry:masterfrom Sep 6, 2022
Merged
Conversation
neersighted
approved these changes
Sep 6, 2022
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM -- glad this was as simple as I asserted it was 😆
neersighted
added
impact/backport
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6430-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9ed1f052fec72ec5dc83c3923d56159ac7fb325
# Push it to GitHub
git push --set-upstream origin backport-6430-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2Then, create a pull request where the |
This was referenced Sep 6, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #6138
Use
poetry -m pip ...instead of calling pip directly so that pip can update itself on Windows.Just to be sure that this has no influence on performance, a little test:
Sample output:
As expected it makes no difference whether pip is called directly or as module.