Skip to content

Comments

fix: write to stderr in utils.env#6429

Merged
neersighted merged 1 commit intopython-poetry:masterfrom
neersighted:env_to_stderr
Sep 6, 2022
Merged

fix: write to stderr in utils.env#6429
neersighted merged 1 commit intopython-poetry:masterfrom
neersighted:env_to_stderr

Conversation

@neersighted
Copy link
Member

This is a quick fix to avoid polluting stdout unexpectedly when Poetry's
environment management comes into play.

It's apparent from how much the complexity of this file has grown that
this needs to be refactored moderately, as well as each major class
deserving its own source file.

Future work should also include a rethink of how IO objects are passed
around the codebase, how we reason about verbosity at a function level,
and how code is re-used -- one command may wish to output to stdout, but
if that code is reused by another command, the calculus of what is
command output and what is informative (or even needs to be hidden/shown
based on verbosity level) changes.

Work on output would likely have to be fairly comprehensive and
invasive, but things have grown complex enough that a top-down design
pass is likely the best route.

Regardless, this is a simple change today, and low risk. Resolves #6427.

This is a quick fix to avoid polluting stdout unexpectedly when Poetry's
environment management comes into play.

It's apparent from how much the complexity of this file has grown that
this needs to be refactored moderately, as well as each major class
deserving its own source file.

Future work should also include a rethink of how IO objects are passed
around the codebase, how we reason about verbosity at a function level,
and how code is re-used -- one command may wish to output to stdout, but
if that code is reused by another command, the calculus of what is
command output and what is informative (or even needs to be hidden/shown
based on verbosity level) changes.

Work on output would likely have to be fairly comprehensive and
invasive, but things have grown complex enough that a top-down design
pass is likely the best route.

Regardless, this is a simple change today, and low risk. Resolves python-poetry#6427.
@neersighted neersighted merged commit 47255c4 into python-poetry:master Sep 6, 2022
@neersighted neersighted added kind/enhancement Not a bug or feature, but improves usability or performance impact/changelog Requires a changelog entry labels Sep 17, 2022
@neersighted neersighted added this to the 1.3 milestone Sep 17, 2022
@neersighted neersighted deleted the env_to_stderr branch September 17, 2022 15:24
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

impact/changelog Requires a changelog entry kind/enhancement Not a bug or feature, but improves usability or performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsolicited messages output to stdout

2 participants