not every GroupCommand needs to be an EnvCommand#6282
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Aug 31, 2022
Merged
not every GroupCommand needs to be an EnvCommand#6282neersighted merged 1 commit intopython-poetry:masterfrom
neersighted merged 1 commit intopython-poetry:masterfrom
Conversation
dimbleby
force-pushed
the
disentangle-env-command-somewhat
branch
from
48cbfb7 to
0fc1e3b
Compare
Contributor
Author
|
Arguably not every Another day, maybe... |
Contributor
Author
|
actually let's do that while we're here, you can always reject the second commit if it's too much |
Contributor
Author
|
ugh no, the |
dimbleby
force-pushed
the
disentangle-env-command-somewhat
branch
from
cead246 to
0fc1e3b
Compare
neersighted
approved these changes
Aug 31, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to #6275 and python-poetry/poetry-plugin-export#78
Not every
GroupCommandneeds to be anEnvCommand(though it's true that everyGroupCommandin this repository is also anEnvCommand, so this refactoring changes nothing here).The intention is to make a change to the export plugin so that the
ExportCommandcan be aGroupCommandbut not anEnvCommand: it does need access to the group options, but it does not need a virtual environment.