repository: keep (uncanonicalized) pretty_name#6237
Merged
neersighted merged 2 commits intopython-poetry:masterfrom Aug 26, 2022
Merged
repository: keep (uncanonicalized) pretty_name#6237neersighted merged 2 commits intopython-poetry:masterfrom
neersighted merged 2 commits intopython-poetry:masterfrom
Conversation
Contributor
|
interesting canonicalization still creeps in for extras somewhere, I haven't tried to figure out where. Eg if you add dev = ["coverage[toml] (==5.0.4)", "cryptography (>=3.3.1)", "mypy", "pre-commit", "pytest (>=6.0.0,<7.0.0)", "sphinx", "sphinx-rtd-theme", "zope-interface"]
docs = ["sphinx", "sphinx-rtd-theme", "zope-interface"]although |
neersighted
previously approved these changes
Aug 25, 2022
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
I'm not the biggest fan of the inline canonicalization -- I'd rather see a variable to hold the canon form. That being said, LGTM even if you disagree.
dimbleby
reviewed
Aug 25, 2022
…_name is equal to pretty_name)
radoering
force-pushed
the
keep-pretty-name
branch
from
5428048 to
ff834f4
Compare
dimbleby
approved these changes
Aug 26, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockfiles created with 1.2rc1 are not compatible with 1.1 if there is a dependency with a dot in its name (e.g.
discord.py), because 1.1 applies a half-hearted normalization not converting dot to dash (writingdiscord.pyin the lockfile) and 1.2rc1 does a complete normalization so thatdiscord.pyis normalized todiscord-py, which is written to the lockfile.However, when looking at
poetry/src/poetry/packages/locker.py
Line 388 in 4392bd6
we can see that the intention has always been to write pretty name (instead of the canonicalized name) into the lockfile. Considering that, half-hearted normalization vs. complete normalization is not the actual issue.
The actual issue is that pretty name got lost unintionally in the process of looking up dependencies in repositories. This PR ensures that pretty name is not lost anymore.