installer: use locked version of vcs dependency with extras instead of latest#6185
Merged
radoering merged 1 commit intopython-poetry:masterfrom Aug 19, 2022
Merged
Conversation
radoering
force-pushed
the
fix-locked-vcs-dep-with-extras
branch
from
ae17ac3 to
48fa40b
Compare
radoering
force-pushed
the
fix-locked-vcs-dep-with-extras
branch
from
48fa40b to
9468b47
Compare
radoering
changed the title
mkniewallner
approved these changes
Aug 19, 2022
| locker.mock_lock_data(fixture("with-vcs-dependency-with-extras")) | ||
| expected_reference = "123456" | ||
| else: | ||
| expected_reference = "9cf87a285a2d3fbb0b9fa621997b3acc3631ed24" |
Member
There was a problem hiding this comment.
nit: Given our growing usage of this value in tests, a follow-up PR that defines it in a reusable constant may make it clearer where it comes from (I'd be happy to do the change).
This was referenced Aug 19, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #6184