avoid tomlkit versions with memory leak#6160
Merged
radoering merged 1 commit intopython-poetry:masterfrom Aug 13, 2022
Merged
Conversation
mkniewallner
previously approved these changes
Aug 13, 2022
Member
mkniewallner
left a comment
mkniewallner
left a comment
There was a problem hiding this comment.
Just a suggestion to add a comment linking to python-poetry/tomlkit#225 to better explain why we want to avoid those versions, but LGTM otherwise.
radoering
force-pushed
the
avoid-bad-tomlkit-versions
branch
from
f2bbade to
5d4da09
Compare
mkniewallner
approved these changes
Aug 13, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #6144