move export code into export plugin#6128
Conversation
radoering
force-pushed
the
move-code-to-poetry-plugin-export
branch
from
3f1d53b to
ab53b9b
Compare
radoering
force-pushed
the
move-code-to-poetry-plugin-export
branch
from
ab53b9b to
d8a63c7
Compare
|
|
||
| return nested_dependencies.items() | ||
|
|
||
| def get_project_dependency_packages( |
There was a problem hiding this comment.
A quick GitHub search shows that this is at least used by one popular project: https://github.com/cloud-custodian/cloud-custodian/blob/318f2b4b1c81b4ffae3474c92038ad328ce00dab/tools/dev/poetrypkg.py#L221-L223.
Not that this holds us from removing this method, but we should probably mention this removal in 1.2 release notes.
There was a problem hiding this comment.
Good point. I agree we should mention that the functionality has been moved to poetry-plugin-export.
I was just thinking about whether we should deprecate the methods and call the functions in the plugin but I don't think that's necessary since we moved the complete export code between 1.1 and 1.2 so that can't be imported as before either. Further, calling export code here is counterproductive for disentangling poetry and poetry-plugin-export. Thus, a notice in the changelog must suffice.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
follow up of python-poetry/poetry-plugin-export#94
Requires a release of poetry-plugin-export with the mentioned change