disambiguate direct-origin dependencies in show-outdated#6016
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Aug 28, 2022
Merged
disambiguate direct-origin dependencies in show-outdated#6016neersighted merged 1 commit intopython-poetry:masterfrom
neersighted merged 1 commit intopython-poetry:masterfrom
Conversation
dimbleby
changed the title
dimbleby
force-pushed
the
show-outdated-with-repeats
branch
from
13d28ae to
9b5d364
Compare
neersighted
force-pushed
the
show-outdated-with-repeats
branch
from
9b5d364 to
8201617
Compare
Member
mkniewallner
left a comment
mkniewallner
left a comment
There was a problem hiding this comment.
Since we have a way to reproduce the problem, should we add a non-regression test?
Contributor
Author
|
sure, go for it |
dimbleby
force-pushed
the
show-outdated-with-repeats
branch
from
8201617 to
38936d8
Compare
neersighted
approved these changes
Aug 28, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you have, say:
and go
poetry show --outdatedthen you hit the runtime errorUnknown direct dependency type None.The reason is that poetry appears twice, once as a direct dependency and once not. And we happen to search for the direct dependency using the one that isn't, if you see what I mean.
This MR also improves the error message by saying which package is the problematic one.