Small poetry init fixes#5946
Merged
mkniewallner merged 1 commit intopython-poetry:masterfrom Jul 3, 2022
wieczorek1990:fix-init-and-messages
Merged
Small poetry init fixes#5946mkniewallner merged 1 commit intopython-poetry:masterfrom wieczorek1990:fix-init-and-messages
mkniewallner merged 1 commit intopython-poetry:masterfrom
wieczorek1990:fix-init-and-messages
Conversation
wieczorek1990
commented
Jul 3, 2022
wieczorek1990
commented
- Fixed invalid authors field population
- Fixed no info about skipping while adding packages
Contributor
|
Edited because I misunderstood. Conceptually you are removing surrounding single quotes rather than apostrophes (admittedly they look the same!) I don't see any surrounding single quotes in names generated from VCS config. What is your setup that does give them? |
Author
|
Removing only from the beginning and ending.
Now instead of:
Łukasz Wieczorek ***@***.***>
I get:
’Łukasz Wieczorek’ ***@***.***’>
It is a bug and does cause error when publishing.
W dniu niedz., 3.07.2022 o 15:15 David Hotham ***@***.***>
napisał(a):
… Why removing apostrophes - do they cause a problem?
They're quite common in some names - eg Ronnie O'Sullivan. Why should they
not be allowed in poetry projects?
—
Reply to this email directly, view it on GitHub
<#5946 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMRLKYICJ2ZNIIN57X65UTVSGHAHANCNFSM52QURBLA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
I had bad data inputed in |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.