Skip to content

Comments

Fix pypi token keyrinerror (#5189)#5911

Merged
Secrus merged 20 commits intopython-poetry:masterfrom
John15321:5189-pypi-token-keyrinerror
Aug 22, 2022
Merged

Fix pypi token keyrinerror (#5189)#5911
Secrus merged 20 commits intopython-poetry:masterfrom
John15321:5189-pypi-token-keyrinerror

Conversation

@John15321
Copy link
Contributor

@John15321 John15321 commented Jun 25, 2022

Pull Request Check List

Resolves: #5189

  • Added tests for changed code.
  • Updated documentation for changed code.

@John15321 John15321 changed the base branch from develop to master June 25, 2022 14:11
@John15321 John15321 marked this pull request as ready for review June 25, 2022 17:47
@John15321 John15321 force-pushed the 5189-pypi-token-keyrinerror branch from e688067 to 8a6585f Compare June 25, 2022 17:48
@John15321 John15321 changed the title 5189 pypi token keyrinerror 5189 fix pypi token keyrinerror Jun 25, 2022
@John15321 John15321 changed the title 5189 fix pypi token keyrinerror Fix pypi token keyrinerror (#5189) Jun 25, 2022
@finswimmer finswimmer requested a review from neersighted July 1, 2022 19:20
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Secrus's changes are addressed.

@John15321
Copy link
Contributor Author

I will fix this PR this weekend, really sorry for making it so late

@John15321 John15321 requested review from Secrus and neersighted and removed request for Secrus August 18, 2022 07:14
@John15321 John15321 requested review from Secrus and removed request for neersighted August 19, 2022 14:07
@John15321 John15321 requested a review from neersighted August 22, 2022 09:05
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Secrus Secrus merged commit 386cf9c into python-poetry:master Aug 22, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POETRY_PYPI_TOKEN_PYPI KeyRingError in GitHub Actions

7 participants