Fix shell activation for zsh#5795
Merged
Secrus merged 6 commits intopython-poetry:masterfrom Sep 6, 2022
Merged
Conversation
Secrus
approved these changes
Sep 6, 2022
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Shell Activation For ZSH
This PR resolves an issue wherein poetry will clear the
PATHon zsh. The activation script contains a number of if statements of the following form:These constructs are valid in bash, although zsh fails to negate the conditional except when placed in emulation mode:
When bash is used as an emulator to source the script, it functions correctly:
It's important to note that this doesn't place the entire shell into bash emulation mode; only the activate script is sourced as bash.
Any guidance on what tests should be added for this PR would be appreciated.