Skip to content

Comments

pypi: do not raise exception on 404#5698

Merged
neersighted merged 2 commits intopython-poetry:masterfrom
abn:fix-pypi-404
May 27, 2022
Merged

pypi: do not raise exception on 404#5698
neersighted merged 2 commits intopython-poetry:masterfrom
abn:fix-pypi-404

Conversation

@abn
Copy link
Member

@abn abn commented May 26, 2022

Resolves: #5682

Writing a test case here is significantly more effort as this will require some form if setup where we use http mocks instead of current MockRepository._get monkey patching.

@abn abn requested a review from a team May 26, 2022 22:00
Secrus
Secrus previously approved these changes May 26, 2022
neersighted
neersighted previously approved these changes May 27, 2022
@abn abn dismissed stale reviews from neersighted and Secrus via 9e5cbf3 May 27, 2022 18:47
@abn abn requested review from Secrus and neersighted May 27, 2022 18:57
@neersighted neersighted merged commit ec89ac4 into python-poetry:master May 27, 2022
@abn abn deleted the fix-pypi-404 branch June 6, 2022 20:07
@abn abn mentioned this pull request Jun 6, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current master falls back to PyPi when using private repo.

4 participants