Skip to content

Comments

poc: rely on poetry to manage pep517 build env#5650

Closed
abn wants to merge 1 commit intopython-poetry:mainfrom
abn:bundle-build-pep517
Closed

poc: rely on poetry to manage pep517 build env#5650
abn wants to merge 1 commit intopython-poetry:mainfrom
abn:bundle-build-pep517

Conversation

@abn
Copy link
Member

@abn abn commented May 19, 2022

No description provided.

@abn abn force-pushed the bundle-build-pep517 branch from ff4c70e to c7dfdf7 Compare May 19, 2022 23:52
@neersighted
Copy link
Member

This looks really promising -- I've always hated the Python-in-strings in that file, and this lets use further re-use and exercise our internal installer while also moving away from strings-as-code.

@abn
Copy link
Member Author

abn commented May 23, 2022

The only reason I am not aggressive on this yet, is that this seems to, for some reason, take a longer time per environment (likely due to the solver). Need to get some metrics on that before I can be really sure though. But there are areas of improvements here.

Bypassing the solver might be an option, but we could end up with .... bad environments.

@Secrus
Copy link
Member

Secrus commented Nov 16, 2022

Quick note, pypa is hcanging pep517 name to pyproject-hooks https://github.com/pypa/pyproject-hooks might be worth changing it when this PR will be revived.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants