Added virtualenvs.prompt option to config#5606
Merged
neersighted merged 7 commits intopython-poetry:masterfrom May 23, 2022
Merged
Added virtualenvs.prompt option to config#5606neersighted merged 7 commits intopython-poetry:masterfrom
neersighted merged 7 commits intopython-poetry:masterfrom
Conversation
dimbleby
reviewed
May 14, 2022
|
Deploy preview for website ready! Built with commit 789c651. |
neersighted
requested changes
May 18, 2022
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
Looks like this needs a bit more touch-up to merge.
Also, do you know if this respects $VIRTUAL_ENV_DISABLE_PROMPT?
Member
Author
@neersighted This is using built-in options from |
Secrus
force-pushed
the
virtualenv-prompt-opt
branch
from
24ab314 to
966aed0
Compare
neersighted
approved these changes
May 23, 2022
2 tasks
Merged
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3055
Since the previous PR on this issue (#3057) has gone stale with no changes since December 2020, I decided to take it upon myself and bring it to life. Some code was taken from the original PR, but as Poetry changed over this time, I had to make some changes of my own. I am not sure whether I did it right, in particularly:
src/poetry/config/config.py:174function (did my best to make mypy happy)tests/inspection/test_info.py:229. Don't really understand how that part works, especially what.call_countis.