ensure setup.py editable builds do not use pep517#5590
Merged
neersighted merged 2 commits intopython-poetry:masterfrom May 11, 2022
Merged
ensure setup.py editable builds do not use pep517#5590neersighted merged 2 commits intopython-poetry:masterfrom
neersighted merged 2 commits intopython-poetry:masterfrom
Conversation
Prior to this change when Poetry builds a project with a setup.py file, as in the case when `generate-setup-file` was set to true, `pip` fallback was invoked with a PEP 517 isolated build causing it to fail. This was a regression in functionality from Poetry 1.1 build script usage. However, note that build script usage is an experimental feature.
abn
force-pushed
the
fix-editable-with-setup-py
branch
from
e1dc56c to
d512a2a
Compare
Closed
neersighted
approved these changes
May 11, 2022
2 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change when Poetry builds a project with a setup.py file, as in the case when
generate-setup-filewas set to true,pipfallback was invoked with a PEP 517 isolated build causing it to fail.This was a regression in functionality from Poetry 1.1 build script usage. However, note that build script usage is an experimental feature.
Resolves: #4979