refactor dependency specification parsing logic#5554
Merged
neersighted merged 2 commits intopython-poetry:masterfrom May 7, 2022
Merged
refactor dependency specification parsing logic#5554neersighted merged 2 commits intopython-poetry:masterfrom
neersighted merged 2 commits intopython-poetry:masterfrom
Conversation
abn
force-pushed
the
refactor-init-parse-requirements
branch
from
7d85d60 to
329908f
Compare
This change moves, cleans up and refactors dependency specification parsing logic from `InitCommand` to `poetry.utils.dependency_specification`. This is done to improve usability and maintainability of this logic.
With this change, users can now add dependencies using valid PEP 508 strings.
abn
force-pushed
the
refactor-init-parse-requirements
branch
from
cb05e08 to
49dda75
Compare
neersighted
approved these changes
May 7, 2022
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
This is a whole lot cleaner and easier to read -- nice work!
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves, cleans up and refactors dependency specification parsing logic from
InitCommandtopoetry.utils.dependency_specification. This is done to improve usability and maintainability of this logic.This has been bugging me for a while now, so decided to clean it up a bit.
Additionally, with this change, users can now add dependencies using valid PEP 508 strings.