Skip to content

Comments

add initial support for single page repositories (sources)#5517

Merged
abn merged 2 commits intopython-poetry:masterfrom
abn:find-links-html
May 7, 2022
Merged

add initial support for single page repositories (sources)#5517
abn merged 2 commits intopython-poetry:masterfrom
abn:find-links-html

Conversation

@abn
Copy link
Member

@abn abn commented Apr 29, 2022 •
edited
Loading

This change allows users to make use of find-links style single page
sources that do not present a PEP 503 simple API repository.

Resolves: #5516

Example Configuration

[[tool.poetry.source]]
name = "jax"
url = "https://storage.googleapis.com/jax-releases/jax_releases.html"

Testing

Using pipx

pipx install --suffix=@5517 'poetry @ git+https://github.com/python-poetry/poetry.git@refs/pull/5517/head'

Using a container (podman | docker)

podman run --rm -i --entrypoint bash docker.io/python:3.10 <<EOF
set -xe
python -m pip install -q git+https://github.com/python-poetry/poetry.git@refs/pull/5517/head
poetry new foobar
pushd foobar
poetry source add jax https://storage.googleapis.com/jax-releases/jax_releases.html
poetry add -vvv --lock --source jax jaxlib
cat poetry.lock
EOF

@abn abn requested a review from a team April 29, 2022 00:40
@abn abn force-pushed the find-links-html branch from fc3e8e9 to 9dcae01 Compare April 29, 2022 00:42
@abn abn changed the title add initial support for single page repositories add initial support for single page repositories (sources) Apr 29, 2022
@abn abn mentioned this pull request Apr 29, 2022
Closed
2 tasks
@abn
Copy link
Member Author

abn commented Apr 29, 2022

Change was verified as working in #5516.

@lecardozo lecardozo mentioned this pull request May 5, 2022
Closed
3 tasks
@abn abn force-pushed the find-links-html branch 2 times, most recently from 183cc08 to 4b399c7 Compare May 7, 2022 15:45
neersighted
neersighted reviewed May 7, 2022
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the name of create_legacy_repository might be worth changing, but otherwise this LGTM.

abn added 2 commits May 7, 2022 19:14
@abn
add initial support for single page repositories
03bc5dc 
This change allows users to make use of find-links style single page
sources that do not present a PEP 503 simple API repository.
@abn
factory: rename create_legacy_repository
18c75b7
@abn abn force-pushed the find-links-html branch from 4b399c7 to 18c75b7 Compare May 7, 2022 17:16
@abn
Copy link
Member Author

abn commented May 7, 2022

I feel like the name of create_legacy_repository might be worth changing, but otherwise this LGTM.

Sounds like a good plan.

@abn abn requested a review from neersighted May 7, 2022 17:17
@abn abn merged commit 4838c9f into python-poetry:master May 7, 2022
@abn abn deleted the find-links-html branch May 7, 2022 17:36
@abn abn mentioned this pull request May 8, 2022
Closed
@abn abn mentioned this pull request Jun 6, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@neersighted neersighted neersighted approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installing JAX with gpu/tpu support using poetry

2 participants

@abn @neersighted