fix(link_sources): don't bail on an invalid version#5484
fix(link_sources): don't bail on an invalid version#5484abn merged 2 commits intopython-poetry:masterfrom
Conversation
|
cc. @abn and @radoering :) |
|
@lovesegfault Just wanted to ask if you think you'll find the time to write the tests in the next one/two weeks? I'd really like to include this fix in the next pre-release to avoid a regression? 😀 |
Hey, I'm currently changing jobs and moving cities, I don't think I'll have time to hack on this for at least another couple weeks. I can try to apply your suggestion quickly today, but I can't spend more time chasing after the root cause here. |
|
Don't bother. If you don't mind I can add some tests myself. I appreciate your discovery and analysis of the issue. |
Please don't hesitate to push to this branch, I don't mind at all :) |
|
@radoering I was fixing something related; pushed up a test case for this with some minor changes to original. |
|
@abn Just added the fix for the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #5476
Registries can have packages with broken versions, which we need to just ignore.
As-is the code will hard-fail when it encounters anything with a version it
cannot parse.