Skip to content

Comments

fix(link_sources): don't bail on an invalid version#5484

Merged
abn merged 2 commits intopython-poetry:masterfrom
lovesegfault:fix-registries
May 6, 2022
Merged

fix(link_sources): don't bail on an invalid version#5484
abn merged 2 commits intopython-poetry:masterfrom
lovesegfault:fix-registries

Conversation

@lovesegfault
Copy link
Contributor

Pull Request Check List

Resolves: #5476

Registries can have packages with broken versions, which we need to just ignore.
As-is the code will hard-fail when it encounters anything with a version it
cannot parse.

@lovesegfault
Copy link
Contributor Author

cc. @abn and @radoering :)

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radoering
Copy link
Member

@lovesegfault Just wanted to ask if you think you'll find the time to write the tests in the next one/two weeks? I'd really like to include this fix in the next pre-release to avoid a regression? 😀

@lovesegfault
Copy link
Contributor Author

@lovesegfault Just wanted to ask if you think you'll find the time to write the tests in the next one/two weeks? I'd really like to include this fix in the next pre-release to avoid a regression? grinning

Hey, I'm currently changing jobs and moving cities, I don't think I'll have time to hack on this for at least another couple weeks.

I can try to apply your suggestion quickly today, but I can't spend more time chasing after the root cause here.

@radoering
Copy link
Member

Don't bother. If you don't mind I can add some tests myself. I appreciate your discovery and analysis of the issue.

@lovesegfault
Copy link
Contributor Author

Don't bother. If you don't mind I can add some tests myself. I appreciate your discovery and analysis of the issue.

Please don't hesitate to push to this branch, I don't mind at all :)

@abn abn force-pushed the fix-registries branch from 7ce865f to 7a81447 Compare May 5, 2022 20:45
@abn
Copy link
Member

abn commented May 5, 2022

@radoering I was fixing something related; pushed up a test case for this with some minor changes to original.

@abn abn force-pushed the fix-registries branch from 7a81447 to 405c10d Compare May 5, 2022 20:59
@radoering
Copy link
Member

@abn Just added the fix for the else path, added some necessary checks, removed some unnecessary checks and added some more narrow unit tests.

@abn abn dismissed radoering’s stale review May 6, 2022 06:37

Resolved

@abn abn merged commit 0d418fc into python-poetry:master May 6, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Private repositories broken after bdfdc62

3 participants