Skip to content

Comments

make no-pip and no-setuptools config explicit#5455

Merged
abn merged 1 commit intopython-poetry:masterfrom
abn:expose-no-pip-setuptool-flags
May 7, 2022
Merged

make no-pip and no-setuptools config explicit#5455
abn merged 1 commit intopython-poetry:masterfrom
abn:expose-no-pip-setuptool-flags

Conversation

@abn
Copy link
Member

@abn abn commented Apr 15, 2022 •
edited
Loading

This makes the virtualenv.options.no-pip and virtualenv.options.no-setuptools options explicitly available to users. We default these to false as otherwise it can cause breakages for certain development tools.

Using pipx

pipx install --suffix=@5455 'poetry @ git+https://github.com/python-poetry/poetry.git@refs/pull/5455/head'

Using a container (podman | docker)

podman run --rm -i --entrypoint bash docker.io/python:3.10 <<EOF
set -xe
python -m pip install --disable-pip-version-check -q git+https://github.com/python-poetry/poetry.git@refs/pull/5455/head 2>/dev/null
poetry new foobar
pushd foobar
poetry config virtualenvs.options.no-pip true
poetry config virtualenvs.options.no-setuptools true
poetry run pip freeze
poetry run pip --version
poetry run pip install -q pip
poetry run pip --version
EOF

Output

+ python -m pip install --disable-pip-version-check -q git+https://github.com/python-poetry/poetry.git@refs/pull/5455/head
+ poetry new foobar
Created package foobar in foobar
+ pushd foobar
/foobar /
+ poetry config virtualenvs.options.no-pip true
+ poetry config virtualenvs.options.no-setuptools true
+ poetry run pip freeze
Creating virtualenv foobar-lWDpn5M1-py3.10 in /root/.cache/pypoetry/virtualenvs
+ poetry run pip --version
pip 22.0.4 from /usr/local/lib/python3.10/site-packages/virtualenv/seed/wheels/embed/pip-22.0.4-py3-none-any.whl/pip (python 3.10)
+ poetry run pip install -q pip
+ poetry run pip --version
pip 22.0.4 from /root/.cache/pypoetry/virtualenvs/foobar-lWDpn5M1-py3.10/lib/python3.10/site-packages/pip (python 3.10)

@abn abn requested a review from a team April 15, 2022 12:49
@abn
make no-pip and no-setuptools config explicit
6696468 
This makes the `virtualenv.options.no-pip` and
`virtualenv.options.no-setuptools` options explicitly available to
users.

We default these to false as otherwise it can cause breakages for
certain development tools.
@abn abn force-pushed the expose-no-pip-setuptool-flags branch from cf2e22e to 6696468 Compare April 15, 2022 13:03
@abn abn merged commit d2474b6 into python-poetry:master May 7, 2022
@abn abn deleted the expose-no-pip-setuptool-flags branch May 7, 2022 13:44
@abn abn mentioned this pull request Jun 6, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abn