Skip to content

Comments

All extras#5452

Merged
neersighted merged 8 commits intopython-poetry:masterfrom
kroeschl:all-extras
Jun 4, 2022
Merged

All extras#5452
neersighted merged 8 commits intopython-poetry:masterfrom
kroeschl:all-extras

Conversation

@kroeschl
Copy link
Contributor

@kroeschl kroeschl commented Apr 14, 2022

Add --all-extras flag to install command

Resolves: #3413

  • Added tests for changed code.
  • Updated documentation for changed code.

Add an --all-extras flag to the install command for projects which use multiple sets of extras. Update documentation for the new flag.

@abn abn added the area/cli Related to the command line label Apr 14, 2022
@kroeschl kroeschl mentioned this pull request Apr 15, 2022
Closed
2 tasks
@kroeschl kroeschl marked this pull request as ready for review April 15, 2022 14:46
abn
abn previously requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kroeschl. Looks good, single comment.

@kroeschl kroeschl requested a review from abn April 18, 2022 18:38
l0b0
l0b0 reviewed Apr 18, 2022
View reviewed changes
tests/console/commands/test_install.py Outdated
assert tester.status_code == 1
assert (
tester.io.fetch_error()
== "You cannot specify explicit `--extras` while installing `--all-extras`.\n"
Copy link

@l0b0 l0b0 Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about using --all-extras as words rather than treating it as a single token in this error message. I'd expect something like "You can't specify both --extras and --all-extras.".

@pkulev
Copy link
Contributor

pkulev commented Apr 26, 2022 •
edited
Loading

Will --extras all be a better choice?

@l0b0
Copy link

l0b0 commented Apr 26, 2022

Will --extras all a better choice?

No, that makes for a "magic" value which could break existing setups.

@kroeschl
Copy link
Contributor Author

kroeschl commented Apr 26, 2022

Will --extras all a better choice?

No, that makes for a "magic" value which could break existing setups.

If we really wanted to go that route, --extras "*" or similar would work better since Poetry (at least 1.1.13) currently chokes on an extras group named *, so no one could be depending on it.

@l0b0
Copy link

l0b0 commented Apr 26, 2022

Will --extras all a better choice?

No, that makes for a "magic" value which could break existing setups.

If we really wanted to go that route, --extras "*" or similar would work better since Poetry (at least 1.1.13) currently chokes on an extras group named *, so no one could be depending on it.

I'd avoid that too:

  • It's another magic value, unfamiliar to anyone who isn't using globs.
  • People familiar with globs will complain that it can't be used like an actual glob, for example in --extras='backend-*'.

neersighted
neersighted reviewed Jun 4, 2022
View reviewed changes
neersighted
neersighted reviewed Jun 4, 2022
View reviewed changes
neersighted
neersighted reviewed Jun 4, 2022
View reviewed changes
@neersighted
Copy link
Member

neersighted commented Jun 4, 2022

pre-commit.ci autofix

@neersighted neersighted merged commit 7ab0699 into python-poetry:master Jun 4, 2022
@abn abn mentioned this pull request Jun 6, 2022
Merged
@kroeschl
Copy link
Contributor Author

kroeschl commented Jun 7, 2022

Thanks for cleaning this up @neersighted. 👍

@benbz benbz mentioned this pull request Jun 29, 2022
Merged
2 tasks
@rjurney
Copy link

rjurney commented Jul 19, 2022

@neersighted @kroeschl any idea when this will be released? It isn't in 1.1.14 I see.

@kroeschl
Copy link
Contributor Author

kroeschl commented Jul 19, 2022

@neersighted @kroeschl any idea when this will be released? It isn't in 1.1.14 I see.

This is in 1.2.0b2 and later, but it was never ported it back to 1.1.x.

@l0b0 l0b0 mentioned this pull request Jul 25, 2022
Open
32 tasks
@kroeschl kroeschl deleted the all-extras branch July 27, 2022 17:42
kroeschl added a commit to kroeschl/poetry that referenced this pull request Jul 27, 2022
@kroeschl @neersighted
feat: poetry install --all-extras (python-poetry#5452)
d93c417 
Co-authored-by: Bjorn Neergaard <[email protected]>
@neersighted
Copy link
Member

neersighted commented Dec 8, 2022 •
edited
Loading

(in reply to a now deleted comment by @AiGeneratedUsername)

With this merge request you made Poetry functionality incomplete.

The addition of new features in Poetry proper does not relate to the implementation of new features in plugins. I don't think it's helpful or fair to say an accepted change that doesn't scratch your particular itch or do everything you would like to see is deficient in this situation.

In any case, there is an open request on python-poetry/poetry-plugin-export#153 to implement the same feature in the plugin; please add your 👍 there.

@github-actions
Copy link

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@neersighted neersighted neersighted approved these changes

@abn abn Awaiting requested review from abn

+1 more reviewer

@l0b0 l0b0 l0b0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/cli Related to the command line

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flag to install all extras

6 participants

@kroeschl @pkulev @l0b0 @neersighted @rjurney @abn