Skip to content

Comments

locker: sort by name and version so that multiple versions of the sam…#5446

Merged
abn merged 1 commit intopython-poetry:masterfrom
radoering:keep-lock-file-sorted
Apr 26, 2022
Merged

locker: sort by name and version so that multiple versions of the sam…#5446
abn merged 1 commit intopython-poetry:masterfrom
radoering:keep-lock-file-sorted

Conversation

@radoering
Copy link
Member

…e package are sorted

Pull Request Check List

#5435 ensures that (required) locked packages are not dropped when running poetry lock --no-update. Unfortunately, the order of packages in poetry.lock can still change when running poetry lock --no-update because packages were only sorted by name. This PR proposes to sort by name and version.

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering requested a review from a team April 14, 2022 12:18
@abn abn merged commit 0d38a39 into python-poetry:master Apr 26, 2022
@kasteph kasteph mentioned this pull request May 30, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@radoering radoering deleted the keep-lock-file-sorted branch November 24, 2024 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants