Issue #3483 Add cert retrieval for requests#5320
Merged
radoering merged 3 commits intopython-poetry:masterfrom Apr 14, 2022
ITProKyle:bugfix/cert-in-request
Merged
Issue #3483 Add cert retrieval for requests#5320radoering merged 3 commits intopython-poetry:masterfrom ITProKyle:bugfix/cert-in-request
radoering merged 3 commits intopython-poetry:masterfrom
ITProKyle:bugfix/cert-in-request
Conversation
ITProKyle
changed the title
ITProKyle
changed the title
2 tasks
Contributor
|
Thank you for this! |
radoering
requested changes
Apr 13, 2022
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
Just some minor type hints quirks. Otherwise looks fine.
The authenticator.py code already retrieves credentials from the config for every request based on url matching. This change makes the authenticator also retrieve certs from the config for each request based on url matching. Also includes unit tests. - Fixed style issues with black - Fixed broken unit test - Fixed broken unit test for windows - Fixing path issue in unit tests for windows - Fixed cert handling for pathlib paths - Style change to make the linter happy - Rebased and fixed type hint - Fixed a style issue - Applied updates from code review - more revisions based on code review feedback - Some revisions based on code review - Applied code review suggestions and fixed unit tests - Fixed broken code from rebase - Applied fix for linting issue and improved test coverage - Fixed issues with linting and type-checking
Contributor
Author
|
@radoering - your requested changes have been made. When you get a chance, would you please take another look at this. Thanks! |
radoering
approved these changes
Apr 14, 2022
2 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authenticator.py code already retrieves credentials from the config for every request based on url matching.
This change makes the authenticator also retrieve certs from the config for each request based on url matching.
Also includes unit tests.
supersedes #3490 by rebasing to current master.
If accepted, I can also backport it to the 1.1 branch to ship this feature sooner than the 1.2 release as its a blocker for some users of private repositories.
Pull Request Check List
Resolves #3483