Removing unused and unnecessary code#5309
Merged
radoering merged 5 commits intopython-poetry:masterfrom Mar 18, 2022
Merged
Conversation
dimbleby
force-pushed
the
reachable-nonsense
branch
from
fc99b89 to
7c499e2
Compare
because node.seen has been fully populated
dimbleby
force-pushed
the
reachable-nonsense
branch
from
7c499e2 to
4cf4f0c
Compare
Contributor
Author
|
(I have rearranged this and #5305 so that this one contains the refactoring and the other contains only the fix) |
radoering
approved these changes
Mar 18, 2022
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
Good catch and well prepared. At some points, I had to think twice about it, but in the end I am quite sure you are absolutely right. 👍
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
A follow-up to my remark in #5305 that
seenlooked redundant on the node in the solver's depth first search, because the surrounding search already had avisited.The doubt in my mind was that there was a second caller of
reachable(), here, and I hadn't taken the time to figure out the effect on that call site.On reflection it is clear that the
seencache will be populated by the time we get to that second caller - which happens after the depth-first search has completed. As a result, that secondreachable()never returns anything other than an empty list.(I also confirmed this by asserting as much in the code, and verifying that the test suite still passed)
Since nothing seems to be broken by that list being empty, I've assumed that we don't need that second
reachable()call after all; and then it is clear thatseenis indeed redundant. So I've made two commits:seenseen(I probably have given myself a small merge conflict with #5305, happy to sort that out if and when the first of these is merged).