Skip to content

Comments

Test: dependencies not matching the project's python constraint are ignored#5307

Merged
abn merged 1 commit intopython-poetry:masterfrom
radoering:test-ignore-dependencies-not-matching-python-constraint
Mar 26, 2022
Merged

Test: dependencies not matching the project's python constraint are ignored#5307
abn merged 1 commit intopython-poetry:masterfrom
radoering:test-ignore-dependencies-not-matching-python-constraint

Conversation

@radoering
Copy link
Member

@radoering radoering commented Mar 13, 2022

(no matter if the python version is specified by "python" keyword or by "markers")

Pull Request Check List

Relates-to: #4958

Increases test coverage.

  • Added tests for changed code.
  • Updated documentation for changed code.

Picks up the test case from #4958 to increase test coverage. The fix from #4958 is not required because the issue had already been fixed upstream. This upstream fix has been made available via poetry-core 1.1.0a7.

@radoering radoering requested a review from a team March 13, 2022 16:04
@radoering radoering changed the title Test that dependencies not matching the project's python constraint are ignored Test: dependencies not matching the project's python constraint are ignored Mar 23, 2022
@radoering radoering force-pushed the test-ignore-dependencies-not-matching-python-constraint branch from aa9db25 to 67a1202 Compare March 23, 2022 16:33
…gnored

(no matter if the python version is specified by "python" keyword or by "markers")
@radoering radoering force-pushed the test-ignore-dependencies-not-matching-python-constraint branch from 67a1202 to 2dcf1f4 Compare March 23, 2022 16:54
@abn abn merged commit 5900f37 into python-poetry:master Mar 26, 2022
@kasteph kasteph mentioned this pull request May 30, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@radoering radoering deleted the test-ignore-dependencies-not-matching-python-constraint branch November 24, 2024 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants