PEP610: handle optional vcs_info.requested_version#5274
Merged
abn merged 2 commits intopython-poetry:masterfrom Mar 5, 2022
Merged
PEP610: handle optional vcs_info.requested_version#5274abn merged 2 commits intopython-poetry:masterfrom
abn merged 2 commits intopython-poetry:masterfrom
Conversation
As per PEP610, presence of `vcs_info.requested_version` is optional in direct_url.json for vcs packages. Prior to this change, Poetry would crash when loading an environment with a vcs package not installed by Poetry.
Closed
finswimmer
reviewed
Mar 5, 2022
finswimmer
approved these changes
Mar 5, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per PEP610, presence of
vcs_info.requested_versionis optional indirect_url.json for vcs packages. Prior to this change, Poetry would
crash when loading an environment with a vcs package not installed by
Poetry.
This PR also contains a linting fix for issue introduced in #4520.
Reference:
https://www.python.org/dev/peps/pep-0610/#specification