Skip to content

Comments

fix(show): handle missing lockfile#5242

Merged
finswimmer merged 1 commit intopython-poetry:masterfrom
branchv:fix/show-no-lockfile
Feb 28, 2022
Merged

fix(show): handle missing lockfile#5242
finswimmer merged 1 commit intopython-poetry:masterfrom
branchv:fix/show-no-lockfile

Conversation

@branchv
Copy link
Member

@branchv branchv commented Feb 27, 2022

poetry show relies on the existence of poetry.lock to display dependencies, but it currently throws a SolverProblemError if this file doesn't exist yet. This checks if the lockfile is missing and errors, if needed.

Pull Request Check List

Resolves: #5240

  • Added tests for changed code.
  • Updated documentation for changed code.

@branchv branchv force-pushed the fix/show-no-lockfile branch from 835ecc8 to f3d7ad3 Compare February 27, 2022 03:54
@branchv branchv force-pushed the fix/show-no-lockfile branch from f3d7ad3 to 72eedd3 Compare February 27, 2022 22:00
@branchv branchv changed the title fix(show): ensure lockfile exists fix(show): handle missing lockfile Feb 27, 2022
@branchv branchv force-pushed the fix/show-no-lockfile branch from 72eedd3 to feef45f Compare February 27, 2022 22:03
@branchv branchv requested a review from finswimmer February 27, 2022 22:04
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finswimmer finswimmer merged commit e403ff4 into python-poetry:master Feb 28, 2022
@branchv branchv deleted the fix/show-no-lockfile branch February 28, 2022 13:03
@finswimmer finswimmer mentioned this pull request Mar 6, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry show gives clickit "NoSuchOptionException(name)" error

2 participants