get fullpath of given python executable when activating env#5086
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Jan 24, 2022
Merged
Conversation
neersighted
approved these changes
Jan 24, 2022
This was referenced Mar 6, 2022
Merged
2 tasks
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poetry env use pythonleads to strange behavior if the user has changed the current python version by a tool likepyenv.The python version is determined with the current activated python version, but
virtualenv, which is used to create the venv, doesn't recognize the change of the current python version bypyenvand will use the system'spythonto create the venv.This is solved by determine the full executable path for the given
python.Resolves: #5077