pyproject: Drop python 3.6 by tony · Pull Request #5055 · python-poetry/poetry

tony · 2022-01-18T00:30:41Z

Resolves: #4997

Pull Request Check List

Requires Deprecate Python 3.6 poetry-core#263
See also: Deprecate Python 3.6 install.python-poetry.org#11

Resolves: #4997

Added tests for changed code.
Updated documentation for changed code.

neersighted · 2022-01-18T14:19:57Z

There are a couple more things to do here, I think:

the Python version in .flake8
the arguments to pyupgrade in .pre-commit-config.yaml

tony · 2022-01-18T14:32:32Z

There are a couple more things to do here, I think:

the Python version in .flake8

the arguments to pyupgrade in .pre-commit-config.yaml

I will convert it to a draft, handle those things, and also continue to look for any other places

If you notice anything else let me know

tony · 2022-01-18T14:52:20Z

pre-commit.ci autofix

neersighted · 2022-01-18T15:38:53Z

Looks like we can drop the dataclasses dep as the marker (python = "<3.7") makes it a no-op.

I don't have time to look into this, but I also suspect this line can be dropped as the types should be in the stdlib now. I may be wrong, so please look into it before making that change.

tony · 2022-01-20T11:07:24Z

@neersighted

Dropped dataclasses
- poetry-core: Also already dropped dataclasses in Deprecate Python 3.6 poetry-core#263
types-dataclasses: removed

pyproject.toml

tests/installation/test_executor.py

for more information, see https://pre-commit.ci

Co-authored-by: Branch Vincent <[email protected]>

tony · 2022-01-22T17:14:47Z

@branchvincent: Thank you

Rebased.

Can you approve running on python-poetry/poetry-core#263?

tony · 2022-01-22T17:16:45Z

@branchvincent

P.S.

Any preference on how to navigate this? I can merge the commits into mine or re-do them myself.

branchv · 2022-01-22T17:59:17Z

Can you approve running on python-poetry/poetry-core#263?

Unfortunately I don't have access yet 😓 , I've just started helping here. I'll see if I can find someone who does

cc @finswimmer?

Any preference on how to navigate this?

Thanks for checking, but it's fine as is! I only have it as a requirement for another project

I believe there's one more version-gated block we can remove:

poetry/src/poetry/utils/pip.py

Lines 58 to 69 in 28d05d0

    
           if sys.version_info < (3, 7) and not is_wheel: 
        
               # Under certain Python3.6 installs vendored pip wheel does not contain 
        
               # zip-safe pep517 lib. In this cases we create an isolated ephemeral virtual 
        
               # environment. 
        
               with ephemeral_environment( 
        
                   executable=environment.python, with_pip=True, with_setuptools=True 
        
               ) as env: 
        
                   return environment.run( 
        
                       *env.get_pip_command(), 
        
                       *args, 
        
                       env={**os.environ, "PYTHONPATH": str(env.purelib)}, 
        
                   )

Originally from cb14c70, part of python-poetry#3835

branchv

Thanks @tony, this looks good to me. Let's get one more reviewer to approve/merge

tony · 2022-01-22T20:30:02Z

Thanks @tony, this looks good to me. Let's get one more reviewer to approve/merge

Thank you for the review!

Poetry removed 3.6 support in 1.2.0 (as of this commit python-poetry/poetry#5055), so we can't support it here either.

Poetry removed 3.6 support in 1.2.0, so we can't support it here either. This was because 3.6's end-of-life was on December 23, 2021. For more information see: python-poetry/poetry#5055 https://devguide.python.org/versions/ https://peps.python.org/pep-0494/ In addition to removing 3.6 support, we're moving this project to require Python >=3.7 and <4

* Set bash as the default shell This removes the necessity of specifying the shell for every step that uses the shell. * Use the install script from Poetry's website * Include 3.10 in tests * Remove 3.6 support, require >=3.7,<4 Poetry removed 3.6 support in 1.2.0, so we can't support it here either. This was because 3.6's end-of-life was on December 23, 2021. For more information see: python-poetry/poetry#5055 https://devguide.python.org/versions/ https://peps.python.org/pep-0494/ In addition to removing 3.6 support, we're moving this project to require Python >=3.7 and <4 * Use the new plugin add syntax * Create a release GitHub Actions workflow This will make it simpler to release versions in the future. * Bump version to remove pre-release

github-actions · 2024-02-29T17:08:49Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

tony marked this pull request as draft January 18, 2022 14:31

tony dismissed a stale review via 7c9703f January 20, 2022 10:56

branchv reviewed Jan 22, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

branchv reviewed Jan 22, 2022

View reviewed changes

tests/installation/test_executor.py Outdated Show resolved Hide resolved

tony marked this pull request as ready for review January 22, 2022 17:12

tony requested a review from branchv January 22, 2022 17:12

tony and others added 14 commits January 22, 2022 11:14

pyproject: Drop python 3.6

edba6d6

chore: Remove python 3.6 fix for io (python-poetry#4038)

6de7495

chore(pyproject): Set pre-commit version constraint to 3.6

66e912d

chore(pyproject): Update isort and black 3.6 -> 3.7

6d1f893

chore(flake8): Update minimum python version

caffbb3

ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7

db87b62

chore(tox): Remove python 3.6

e5d0bc8

[pre-commit.ci] auto fixes from pre-commit.com hooks

ba77eb7

for more information, see https://pre-commit.ci

chore(tests): Bump unsafe kwargs PY36 (removed) PY37

dad1b0d

build(deps): Drop dataclasses

e308e9d

chore(pre-commit]: Remove types-dataclasses (unneeded <3.7)

70879bb

docs: py36 -> py37

7eb262f

chore(test): Remove redundant argument

5cb7ea6

Co-authored-by: Branch Vincent <[email protected]>

build(deps): Simplify pre-commit usage

5841dc0

Co-authored-by: Branch Vincent <[email protected]>

tony force-pushed the deprecate-python-3.6 branch from aec2dc9 to 5841dc0 Compare January 22, 2022 17:14

tony added 2 commits January 22, 2022 11:17

docs(README): Clarify minimum version is 3.7+

4491c43

docs(README): Note minimum installer version

d3524b1

docs(index): Note minimum version 3.7

96fc506

This was referenced Jan 22, 2022

Deprecate Python 3.6 python-poetry/install.python-poetry.org#11

Closed

Deprecate Python 3.6 python-poetry/poetry-core#263

Merged

tony added 2 commits January 22, 2022 11:29

docs: Update example references of 3.6 to 3.7

10818f1

ci(main,skip): Remove 3.6

941ee5b

tony added 2 commits January 22, 2022 12:05

chore(pip): Remove zip-unsafe workaround for python 3.6

94d9c66

Originally from cb14c70, part of python-poetry#3835

chore: Unused import

34ed253

branchv mentioned this pull request Jan 22, 2022

chore: enable pep 563/585 #5088

Merged

branchv approved these changes Jan 22, 2022

View reviewed changes

neersighted approved these changes Jan 22, 2022

View reviewed changes

finswimmer merged commit a0f3d5a into python-poetry:master Jan 23, 2022

tony deleted the deprecate-python-3.6 branch February 5, 2022 20:22

finswimmer mentioned this pull request Mar 6, 2022

Release 1.2.0b1 #5280

Merged

blackliner mentioned this pull request Aug 31, 2022

1.2.0 install not possible aarch64 #6272

Closed

3 tasks

mpeteuil added a commit to mpeteuil/poetry-dotenv-plugin that referenced this pull request Sep 3, 2022

Remove 3.6 support

25cad4e

Poetry removed 3.6 support in 1.2.0 (as of this commit python-poetry/poetry#5055), so we can't support it here either.

mpeteuil added a commit to mpeteuil/poetry-dotenv-plugin that referenced this pull request Sep 3, 2022

Remove 3.6 support

728b144

Poetry removed 3.6 support in 1.2.0 (as of this commit python-poetry/poetry#5055), so we can't support it here either.

mpeteuil mentioned this pull request Sep 3, 2022

Update Pythons, workflows for Poetry 1.2.0 release mpeteuil/poetry-dotenv-plugin#7

Merged

github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

pyproject: Drop python 3.6#5055

pyproject: Drop python 3.6#5055
finswimmer merged 21 commits intopython-poetry:masterfrom
tony:deprecate-python-3.6

tony commented Jan 18, 2022 •

edited

Loading

Uh oh!

neersighted commented Jan 18, 2022

Uh oh!

tony commented Jan 18, 2022

Uh oh!

tony commented Jan 18, 2022

Uh oh!

neersighted commented Jan 18, 2022 •

edited

Loading

Uh oh!

tony commented Jan 20, 2022

Uh oh!

Uh oh!

Uh oh!

tony commented Jan 22, 2022

Uh oh!

tony commented Jan 22, 2022

Uh oh!

branchv commented Jan 22, 2022

Uh oh!

branchv left a comment

Uh oh!

tony commented Jan 22, 2022

Uh oh!

github-actions bot commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

tony commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Check List

Uh oh!

neersighted commented Jan 18, 2022

Uh oh!

tony commented Jan 18, 2022

Uh oh!

tony commented Jan 18, 2022

Uh oh!

neersighted commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tony commented Jan 20, 2022

Uh oh!

Uh oh!

Uh oh!

tony commented Jan 22, 2022

Uh oh!

tony commented Jan 22, 2022

Uh oh!

branchv commented Jan 22, 2022

Uh oh!

branchv left a comment

Choose a reason for hiding this comment

Uh oh!

tony commented Jan 22, 2022

Uh oh!

github-actions bot commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tony commented Jan 18, 2022 •

edited

Loading

neersighted commented Jan 18, 2022 •

edited

Loading