Skip to content

Comments

Backport mingw bin dir correction to poetry 1.1.x#4942

Merged
finswimmer merged 1 commit intopython-poetry:1.1from
s0600204:mingw-backport
Jan 8, 2022
Merged

Backport mingw bin dir correction to poetry 1.1.x#4942
finswimmer merged 1 commit intopython-poetry:1.1from
s0600204:mingw-backport

Conversation

@s0600204
Copy link
Contributor

In #3713 and its follow-up #4482, the path to python.exe and poetry.exe was corrected for Windows + MinGW on the poetry master branch.

This is a backport of those same changes, for users running poetry 1.1.x


Pull Request Check List

Related: #3713, #4482

  • Added tests for changed code.
    • I think a test for this would require a suitable CI environment (Windows+MinGW) to be set up. However setting that up is a bit beyond the scope of this PR, related as it may be.
  • Updated documentation for changed code.
    • No documentation change needed.

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finswimmer finswimmer merged commit 43943ba into python-poetry:1.1 Jan 8, 2022
@s0600204 s0600204 deleted the mingw-backport branch February 2, 2022 08:03
@finswimmer finswimmer mentioned this pull request Feb 8, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants