Add docs and schema for multiple readme files support#4743
Add docs and schema for multiple readme files support#4743wagnerluis1982 wants to merge 2 commits intopython-poetry:masterfrom wagnerluis1982:feature/multiple-readme-files
Conversation
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
This doc change is relatively meaningless without the core changes to go with it -- by that, I mean that even after your changes are merged into core, they will not be reflected.
Between alpha releases, poetry master normally tracks poetry-core. I would suggest waiting until your PR lands in core, and then updating pyproject.toml to reflect the Git dependency so that your changes can be used.
neersighted
added
status/waiting-on-core
wagnerluis1982
changed the title
|
@neersighted, please remember to also merge this, given core changes at python-poetry/poetry-core#248 is merged 😊 |
|
I'm aware! I'm not sure of merging this yet because of two things -- the schema in this repo is actually useless, so I'm thinking we merge a PR to drop it and drop that change from this PR. Additionally, the docs in |
|
@neersighted did anything change in the meantime or is it still undecided? |
We've had a core release since then, so we should be good to just drop the schema in this PR, and update the docs to reflect the current reality. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
poetry-schema.jsonto match core's versionPull Request Check List
Related to #873