feat: Check all hash types when validating archives#4740
Closed
neersighted wants to merge 2 commits intomasterfrom
Closed
feat: Check all hash types when validating archives#4740neersighted wants to merge 2 commits intomasterfrom
neersighted wants to merge 2 commits intomasterfrom
Conversation
neersighted
added
status/waiting-on-core
neersighted
force-pushed
the
neersighted/hash_algos
branch
from
8b1a3b4 to
a38ec72
Compare
1 task
Member
|
I think we can implement it similarly to what is present in 1.1 (see #4529). To be honest, I forgot to port it to the master branch when fixing it in the 1.1 branch. |
Member
Author
Didn't even see that! I'll port that version to master and push it to this PR in a bit. |
neersighted
force-pushed
the
neersighted/hash_algos
branch
2 times, most recently
from
16c445c to
ad027bb
Compare
neersighted
changed the title
neersighted
commented
Nov 13, 2021
neersighted
force-pushed
the
neersighted/hash_algos
branch
from
ad027bb to
d4498a1
Compare
neersighted
force-pushed
the
neersighted/hash_algos
branch
3 times, most recently
from
dfee00c to
a1245d1
Compare
neersighted
removed
the
status/waiting-on-core
neersighted
force-pushed
the
neersighted/hash_algos
branch
2 times, most recently
from
5e2d872 to
a0dec58
Compare
neersighted
force-pushed
the
neersighted/hash_algos
branch
from
a0dec58 to
439dd97
Compare
|
What's the status of this? Poetry 1.1.11 fails with
1.1.12 fails with: |
This was referenced Mar 15, 2022
Member
Author
|
Closing this as not a complete design/unable to be merged in its present form. |
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.
This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.