Handles name == None case (re: issue #4311, #3628)#4702
Handles name == None case (re: issue #4311, #3628)#4702aalok-sathe wants to merge 1 commit intopython-poetry:masterfrom aalok-sathe:patch-1
Conversation
Addresses issue #4311 and others, related to `canonicalize_name` throwing TypeError because a str or bytes like object was expected.
aalok-sathe
changed the title
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
I'm not sure this is the best way to solve this problem -- one one hand, poetry should probably be more resilient to unexpected problems like empty egg/dist-info. On the other hand, if this is a poetry-managed environment, it's likely that poetry is creating these problems for itself.
I'll have to think about this one personally, after doing some digging and reproduction work.
At the very least, to be merge-able, we need to create a reproduction and regression test for this change.
|
@neersighted You're probably right; I was looking for a quick fix at the time to remove a blockade in a project. Unfortunately I am not able to spend enough time on this at the moment to come up with a better solution. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Addresses issue #4311 and others, related to
canonicalize_namethrowing TypeError because a str or bytes like object was expected.Pull Request Check List
Resolves: #4311, #3628