Skip to content

Comments

Fix for "poetry lock --no-update" so that dependencies with extras are not updated unnecessarily#4618

Merged
neersighted merged 4 commits intopython-poetry:masterfrom
radoering:fix-lock-no-update-for-deps-with-extras
Mar 8, 2022
Merged

Fix for "poetry lock --no-update" so that dependencies with extras are not updated unnecessarily#4618
neersighted merged 4 commits intopython-poetry:masterfrom
radoering:fix-lock-no-update-for-deps-with-extras

Conversation

@radoering
Copy link
Member

@radoering radoering commented Oct 9, 2021

Pull Request Check List

Resolves: #4612
Resolves: #3128
Resolves: #5185

  • Added tests for changed code.
  • Updated documentation for changed code.

When calling poetry lock with --no-update dependencies with extras should not be updated unnecessarily.

@neersighted neersighted self-assigned this Nov 13, 2021
@radoering
Copy link
Member Author

@neersighted: Shall I rebase the branch so that the FreeBSD test can succeed or should I wait for your review?

@neersighted
Copy link
Member

neersighted commented Nov 14, 2021

@neersighted: Shall I rebase the branch so that the FreeBSD test can succeed or should I wait for your review?

Please go ahead and rebase! There are enough changes in master that even non-significantly stale PRs will need to be rebased to have confidence in testing anyway. Thanks!

@radoering radoering force-pushed the fix-lock-no-update-for-deps-with-extras branch 3 times, most recently from 764a964 to 8b5b090 Compare November 21, 2021 05:44
@radoering radoering force-pushed the fix-lock-no-update-for-deps-with-extras branch from e742a8f to 2234ceb Compare February 28, 2022 16:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@radoering radoering deleted the fix-lock-no-update-for-deps-with-extras branch November 24, 2024 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants