Allow for empty choice while selecting dependencies#4606
Merged
abn merged 1 commit intopython-poetry:masterfrom May 20, 2022
Merged
Allow for empty choice while selecting dependencies#4606abn merged 1 commit intopython-poetry:masterfrom
abn merged 1 commit intopython-poetry:masterfrom
Conversation
3 tasks
Member
|
@jacobperron are you still interested in bringing this to Poetry? If so, please merge changes from master branch and resolve potential conflics. This would allow for review to be done. Thanks. |
Secrus
added
area/cli
Fixes python-poetry#2355 This works around an issue with cleo's `Command.choice` implementation. If the user does not make a selection then an AttributeError is raised.
Contributor
Author
|
@Secrus I've rebased on |
Secrus
approved these changes
May 19, 2022
abn
approved these changes
May 20, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2355
This works around an issue with cleo's
Command.choiceimplementation.If the user does not make a selection then an AttributeError is raised.
Pull Request Check List
Resolves: #2355